Improve Name-to-Slug parsing to better align with Netbox UI#809
Open
jantari wants to merge 2 commits intonetbox-community:develfrom
Open
Improve Name-to-Slug parsing to better align with Netbox UI#809jantari wants to merge 2 commits intonetbox-community:develfrom
jantari wants to merge 2 commits intonetbox-community:develfrom
Conversation
added 2 commits
July 7, 2022 09:50
Contributor
|
I don't think stripping out any non-ASCII characters is good for i18n. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#808
New Behavior
Contrast to Current Behavior
The generated slug names will align better with what the Netbox UI would auto-suggest / use and errors due to umlauts in site names are prevented.
Discussion: Benefits and Drawbacks
Changes to the Documentation
I updated the test, but cannot think of anz Wiki or Docs changes required.
Proposed Release Note Entry
Improve Name-to-Slug parsing to better align with Netbox UI
Double Check
develbranch.