create S5732-H24S6Q.yaml #2970
Draft
create S5732-H24S6Q.yaml #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
device model for Huawei switch S5732-H24S6Q
slug changed
airflow modified
modified part number
harryajc
requested changes
Apr 2, 2025
| type: usb-a | ||
| - name: console0 | ||
| type: rj-45 | ||
| power-ports: |
There was a problem hiding this comment.
Hi Thank you for contribution,
Looking at the spec sheet these are hot swappable PSUs therefore they should be modelled as module-bays within the device template with the required PSUs added as modules
harryajc
added
the
status: revisions needed
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
device-types/Huawei/S5732-H24S6Q.yaml:86
- [nitpick] The interface name 'MEth0/0/1' is inconsistent with the naming conventions used for other interfaces (e.g. GigabitEthernet, XGigabitEthernet, 40GE0/0/1) and may be a typo. Consider verifying the intended name and potentially renaming it to match the standard conventions.
- name: MEth0/0/1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added new huawei device model