Add missing HPE OfficeConnect 1920 Series Switches #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
device-types/HPE/OfficeConnect-1920-48G.yml:1
- This file does not include 'front_image' and 'rear_image' keys, which are present in other device definitions. Consider adding these fields for consistent UI display if applicable.
---
device-types/HPE/OfficeConnect-1920-48G-PoE-370W.yml:1
- Unlike other PoE device definitions, this file is missing 'front_image' and 'rear_image' keys. Consider adding these fields to maintain consistency across device definitions.
---
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
device-types/HPE/OfficeConnect-1920-48G.yml:17
- [nitpick] Consider using a consistent naming convention for interfaces across device definitions. For example, use the 'GE1/0/1' format (as in the 8G models) instead of numeric strings.
- name: '1'
device-types/HPE/OfficeConnect-1920-48G-PoE-370W.yml:16
- [nitpick] Consider using a consistent naming convention for interfaces across device definitions. For example, adopt the 'GE1/0/1' format (similar to other models) instead of numeric strings.
- name: '1'
device-types/HPE/OfficeConnect-1920-48G.yml:2
- [nitpick] For consistency with other device definitions, consider adding 'front_image' and 'rear_image' keys even if their values are false.
manufacturer: HPE
harryajc
requested changes
Apr 11, 2025
harryajc
added
the
status: revisions needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://support.hpe.com/hpesc/public/docDisplay?docId=c04478097&docLocale=en_US
Adds the missing: