Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 67 (Sourcery refactored) #128

Closed
wants to merge 1 commit into from
Closed

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Jan 30, 2023

Pull Request #122 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the issue_67 branch, then run:

git fetch origin sourcery/issue_67
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Jan 30, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.04%.

Quality metrics Before After Change
Complexity 4.60 ⭐ 4.56 ⭐ -0.04 👍
Method Length 69.89 🙂 69.89 🙂 0.00
Working memory 7.49 🙂 7.49 🙂 0.00
Quality 72.81% 🙂 72.85% 🙂 0.04% 👍
Other metrics Before After Change
Lines 445 444 -1
Changed files Quality Before Quality After Quality Change
netbox_acls/forms/models.py 72.81% 🙂 72.85% 🙂 0.04% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
netbox_acls/forms/models.py ACLInterfaceAssignmentForm.clean 11 🙂 185 😞 12 😞 45.36% 😞 Try splitting into smaller methods. Extract out complex expressions
netbox_acls/forms/models.py AccessListForm._validate_acl_type_change 6 ⭐ 62 🙂 11 😞 66.76% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Comment on lines -516 to +522
else:
error_interface_already_assigned = (
"Interfaces can only have 1 Access List assigned in each direction."
)
return {
"direction": [error_interface_already_assigned],
assigned_object_type: [error_interface_already_assigned],
}
error_interface_already_assigned = (
"Interfaces can only have 1 Access List assigned in each direction."
)
return {
"direction": [error_interface_already_assigned],
assigned_object_type: [error_interface_already_assigned],
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function ACLInterfaceAssignmentForm._check_if_interface_already_has_acl_in_direction refactored with the following changes:

@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sourcery-ai sourcery-ai bot closed this Jan 30, 2023
@sourcery-ai sourcery-ai bot deleted the sourcery/issue_67 branch January 30, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants