Add model tests (Sourcery refactored) #137

sourcery-ai · 2023-02-03T13:59:01Z

Pull Request #134 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the issue_47 branch, then run:

git fetch origin sourcery/issue_47
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai · 2023-02-03T13:59:07Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 0.40%.

Quality metrics	Before	After	Change
Complexity	15.26 🙂	14.82 🙂	-0.44 👍
Method Length	134.22 😞	134.22 😞	0.00
Working memory	10.26 😞	10.24 😞	-0.02 👍
Quality	48.09% 😞	48.49% 😞	0.40% 👍

Other metrics	Before	After	Change
Lines	363	365	2

Changed files	Quality Before	Quality After	Quality Change
netbox_acls/forms/models.py	48.09% 😞	48.49% 😞	0.40% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
netbox_acls/forms/models.py	ACLInterfaceAssignmentForm.clean	15 🙂	282 ⛔	15 😞	31.91% 😞	Try splitting into smaller methods. Extract out complex expressions
netbox_acls/forms/models.py	AccessListForm.clean	19 😞	236 ⛔	13 😞	33.65% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
netbox_acls/forms/models.py	AccessListForm.__init__	27 😞	194 😞	8 🙂	40.82% 😞	Refactor to reduce nesting. Try splitting into smaller methods
netbox_acls/forms/models.py	ACLExtendedRuleForm.clean	15 🙂	121 😞	6 ⭐	61.28% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

sourcery-ai · 2023-02-07T05:10:42Z

netbox_acls/forms/models.py

-        if self.instance.pk:
-            # Check if Access List has no existing rules before change the Access List's type.
-            if (
+        if (
+            self.instance.pk
+            and (
                acl_type == ACLTypeChoices.TYPE_EXTENDED
                and self.instance.aclstandardrules.exists()
-            ) or (
+            )
+            or (
                acl_type == ACLTypeChoices.TYPE_STANDARD
                and self.instance.aclextendedrules.exists()
-            ):
-                error_message["type"] = [
-                    "This ACL has ACL rules associated, CANNOT change ACL type.",
-                ]
+            )
+        ):
+            error_message["type"] = [
+                "This ACL has ACL rules associated, CANNOT change ACL type.",
+            ]


Function AccessListForm.clean refactored with the following changes:

Merge nested if conditions (merge-nested-ifs)

This removes the following comments ( why? ):

# Check if Access List has no existing rules before change the Access List's type.