Add extra environment variables for SSL encryption to the database #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also included variables in netbox.env
crimmy68
changed the title
Re-ordered variables as indicated by the syntax check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #1105
New Behavior
As suggested by someone else in #1105 , I added extra environment variables for the docker image:
Contrast to Current Behavior
Unable to provide parameters to use SSL encryption to external Postgresql database.
Discussion: Benefits and Drawbacks
Providing these extra environment variables is completely optional so there is no drawback.
However it provides the benefit of providing the option when filling in the extra.py is not an option.
( I don't want to edit code for Kubernetes deployments f.e. )
Changes to the Wiki
N/A
Proposed Release Note Entry
Simply mention the extra options.
potentially a reference to: https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS
Double Check
developbranch.