Skip to content

Bump golang from 1.23.6 to 1.24.0 #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 17, 2025

Bumps golang from 1.23.6 to 1.24.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Feb 17, 2025
@henrybear327 henrybear327 force-pushed the dependabot/docker/golang-1.24.0 branch from e47cc82 to 6fd0343 Compare February 17, 2025 12:19
@henrybear327
Copy link
Collaborator

@jstudler go 1.24 is released! Do we want to bump or wait :) ?

The go.mod base version is still 1.23, I didn't bump that!

@henrybear327 henrybear327 force-pushed the dependabot/docker/golang-1.24.0 branch 2 times, most recently from 95f1af8 to 3cfeb42 Compare February 17, 2025 12:30
@henrybear327 henrybear327 self-assigned this Feb 17, 2025
@henrybear327 henrybear327 force-pushed the dependabot/docker/golang-1.24.0 branch 2 times, most recently from e1244b6 to 3c1d175 Compare February 20, 2025 08:04
@jstudler
Copy link
Contributor

jstudler commented Feb 28, 2025

@jstudler go 1.24 is released! Do we want to bump or wait :) ?

The go.mod base version is still 1.23, I didn't bump that!

I propose to merge #249 before which introduces a lot of e2e tests to be on the safe side.

And we should also bump the base version I guess or what do you think on this one?

@jstudler
Copy link
Contributor

jstudler commented Mar 4, 2025

@dependabot recreate

Dependabot couldn't find the original pull request head commit, e47cc82.
@dependabot dependabot bot force-pushed the dependabot/docker/golang-1.24.0 branch from 3117234 to 90e959f Compare March 4, 2025 13:33
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 10, 2025

Superseded by #262.

@dependabot dependabot bot closed this Mar 10, 2025
@dependabot dependabot bot deleted the dependabot/docker/golang-1.24.0 branch March 10, 2025 12:25
@henrybear327
Copy link
Collaborator

@jstudler go 1.24 is released! Do we want to bump or wait :) ?
The go.mod base version is still 1.23, I didn't bump that!

I propose to merge #249 before which introduces a lot of e2e tests to be on the safe side.

And we should also bump the base version I guess or what do you think on this one?

I don't have a strong opinion regarding if we should bump t 1.24 or not, but Kubernetes usually is fast to adopt the latest go releases to adapt the latest features and fixes. e.g. https://github.com/kubernetes/kubernetes/blob/master/go.mod#L9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants