Skip to content

Remove duplicate kind cluster creation #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

jstudler
Copy link
Contributor

@jstudler jstudler commented Mar 6, 2025

Kind clusters for the e2e tests are implicitly created in the make test-e2e-* targets that are triggered in the Run e2e tests steps of the e2e-tests pipeline. Thus, there is no need for the additional Start kind cluster step in the e2e tests pipeline. This PR removes the additional kind cluster creation.

@jstudler jstudler requested a review from henrybear327 March 6, 2025 07:35
@jstudler jstudler self-assigned this Mar 6, 2025
@jstudler jstudler requested a review from faebr March 6, 2025 08:13
@jstudler jstudler marked this pull request as ready for review March 6, 2025 08:14
@henrybear327 henrybear327 force-pushed the ci/remove-duplicate-kind-creation branch from d707016 to bcfb28a Compare March 10, 2025 14:36
@henrybear327
Copy link
Collaborator

If the test can pass, we can indeed remove those setup parts :)
Good catch!

@jstudler jstudler merged commit 7bcbe12 into main Mar 11, 2025
8 checks passed
@henrybear327 henrybear327 deleted the ci/remove-duplicate-kind-creation branch March 11, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants