Verify prefix length when restoring PrefixClaim from NetBox#373
Merged
Verify prefix length when restoring PrefixClaim from NetBox#373
Conversation
faebr
requested changes
Jul 16, 2025
Collaborator
faebr
left a comment
faebr
left a comment
There was a problem hiding this comment.
Works as expected and I like the tests but the error message can be misleading. Also I think the operator logs should not print the stack traces on such an error since its not an unexpected code error. But this might be out of scope of this mr
faebr
approved these changes
Jul 16, 2025
vaishutin
pushed a commit
to vaishutin/netbox-operator
that referenced
this pull request
Aug 17, 2025
…-community#373) If there is a mismatch of .spec.prefixLength and the prefix length of the Prefix in NetBox that would be restored, NetBox Operator will now longer restore it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a mismatch of .spec.prefixLength and the prefix length of the Prefix in NetBox that would be restored, NetBox Operator will now longer restore it.
Fixes #82