Closes #16786: Clone device location from rack #17508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a device is assigned to a rack, its site and location are cloned from the rack regardless of user input. This also allows some consistency checks to be removed, as inconsistent data would still be overwritten with valid values when saving the Device object.
bctiemann
approved these changes
Sep 16, 2024
jeremystretch
requested changes
Sep 17, 2024
This reverts commit fd309a0.
Instead of an exact match between device and rack location, it is now sufficient if the device location or one of its children contains the selected rack.
alehaa
force-pushed
the
16786-device-location-from-rack
branch
from
59824e4
to
add8640
Compare
|
After re-reading FR #16786 the proposed behavior doesn't seem to be valid. The location to which a device is assigned must match the location of its assigned rack (if any); anything else would be invalid. Please also see my comment on the FR as it sounds like your use case is better solved by the introduction of new filters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16786
To fix errors when selecting a rack of a child location being not part of the parent location, the site and location are now always copied from the rack when a device is assigned to a rack.