Fixes: #20490 - Add filtering of Script objects based on object permissions with custom constraints #21212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bctiemann
requested review from
a team and
jeremystretch
and removed request for
a team
jeremystretch
requested changes
Jan 21, 2026
| Custom scripts have unrestricted access to change anything in the database and are inherently unsafe and should only be installed and run from trusted sources. You should also review and set permissions for who can run scripts if the script can modify any data. | ||
|
|
||
| !!! tip "Permissions for Custom Scripts" | ||
| A user can be granted permissions on all Custom Scripts via the "Managed File" object-level permission. To further restrict a user to only be able to access certain scripts, create an additional permission on the "Script" object type, with appropriate queryset-style constraints matching fields available on Script. For example: |
Member
There was a problem hiding this comment.
This seems very confusing, as "script module" appears as an available object type in the permission form. I don't think we should rely on the ManagedFile model for permissions here, as it's not intended to be a "public" model. Or, if we can't get permissions to work using ScriptModule (a proxy model), we should remove it from the list of available models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20490
Adds the ability to filter Scripts based on custom object-level permissions with
constraintssuch as:Note that this permission is applied against
Scriptobjects, allowing permissions to be applied againstScriptorScriptModuleobjects via ORM lookups; however, access to the overall Scripts page is given via theManagedFileobject type.