Fixes: #19129 - Richer display of MAC addresses in InterfaceTable when multiple MACs are present

[bctiemann]

Fixes: #19129

On the list view for Interface and VMInterface, the presence of multiple MAC addresses on an interface is now communicated in various ways depending on whether one is assigned:

        11:22:33:44:55:66      <-- Single MAC address on interface, assigned as primary
        11:22:33:44:55:66 (2)  <-- Multiple MAC addresses on interface, one assigned as primary
        2 available            <-- 1 or more MAC addresses on interface, none assigned as primary
        -                      <-- No MAC addresses on interface

Note: this same logic is reflected on the interface detail page.

[jeremystretch]

This adds significant overhead as currently implemented, triggering a count of MAC addresses for each interface in the table. Why don't we just introduce a non-default column that lists all assigned MAC addresses (perhaps annotating the primary), like we do for IP addresses? That seems much cleaner IMO, and it ensures the MAC addresses are efficiently prefetched.

[bctiemann]

Agreed, that's a better pattern. Done, also synchronized the vminterface.html MAC Address field HTML with interface.html which was overlooked before.

[jeremystretch]

Same general note as above. Rather than only showing the primary MAC and hinting whether there are other MACs assigned, let's just display all the MACs and annotate the primary.

[jeremystretch]

We should annotate this as primary somehow to avoid confusion with the multi-MAC column.

Suggested change

	verbose_name=_('MAC Address'),
	verbose_name=_('MAC Address (Primary)'),

[jeremystretch]

IMO we should just make this a ManyToManyColumn.

[jeremystretch]

If we keep the TemplateColumn

Suggested change

	<a href="{% url 'ipam:macaddress_list' %}?{{ record|meta:"model_name" }}_id={{ record.pk }}">{{ value.count }}</a>
	<a href="{% url 'dcim:macaddress_list' %}?{{ record|meta:"model_name" }}_id={{ record.pk }}">{{ value.count }}</a>