Fixes #21320: Prevent Rack validation errors when site or optional fields are missing during import #21321
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheus
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
requested changes
Feb 2, 2026
jnovinger
requested changes
Feb 2, 2026
Member
jnovinger
left a comment
jnovinger
left a comment
There was a problem hiding this comment.
Left some thoughts on how you're checking those values safely.
Use `site_id` and `location_id` for validation to avoid triggering related object lookups during import/validation. This aligns the logic with the underlying foreign key fields and prevents `RelatedObjectDoesNotExist` errors when relations are unset. Fixes: #21320
pheus
force-pushed
the
21320-rack-direct-import-rack-has-no-site
branch
from
8860f2c to
75106e1
Compare
jnovinger
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21320
This PR prevents an uncaught exception during Rack direct import/validation when the
siterelation isn’t set (e.g. due to missing/incorrect CSV headers), which previously could raiseRelatedObjectDoesNotExist.Summary of changes
site_id/location_id) instead of accessing related objects directly.Thanks again to @cpt-kernel-afk for the report and sample CSVs, and to @jnovinger for the review/suggestion to use FK IDs here.