Closes #21356: Implement ETag support for REST API#21522
Draft
jeremystretch wants to merge 1 commit intofeaturefrom
Draft
Closes #21356: Implement ETag support for REST API#21522jeremystretch wants to merge 1 commit intofeaturefrom
jeremystretch wants to merge 1 commit intofeaturefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #21356
netbox/netbox/api/viewsets/__init__.py_get_etag()returns a quoted ISO 8601 ETag derived from last_updated (falling back to created). The retrieve() override appends the ETag header to detail responses.retrieve()priority in the MRO over DRF'sRetrieveModelMixin.retrieve().update(): Added an If-Match precondition check per RFC 9110 §13.1.1 — if the header is present and not *, it compares against the current ETag and returns 412 Precondition Failed on mismatch. The response now includes afresh ETag reflecting the updated last_updated value.
create(): Single-object creation responses now include an ETag header. Bulk creation responses do not (no single canonical object).netbox/utilities/testing/api.pytest_get_object(): After the 200 OK assertion, verifies that ChangeLoggingMixin models return an ETag header.test_update_object_with_etag()(new method): End-to-end test that verifies correct-ETag PATCH returns 200 with a changed ETag, and stale-ETag PATCH returns 412.