feat(endpoint): add SVG support for rack elevation endpoint #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeverBehave
requested review from
arthanson,
bctiemann,
jeremystretch and
jnovinger
as code owners
NeverBehave
force-pushed
the
nb/svg-support
branch
from
1a61145 to
cd6d11f
Compare
jnovinger
requested review from
a team and
arthanson
and removed request for
a team,
arthanson,
bctiemann,
jeremystretch and
jnovinger
arthanson
requested changes
Dec 16, 2025
Collaborator
arthanson
left a comment
arthanson
left a comment
There was a problem hiding this comment.
Looks good, just a couple items to clean up.
| and sets appropriate Accept header. If False, expects raw content | ||
| (e.g., SVG, XML) and returns text. Defaults to True. | ||
| ## Note |
Collaborator
There was a problem hiding this comment.
Is this supposed to be here, doesn't seem part of this PR?
Contributor
Author
There was a problem hiding this comment.
This is my note when exploring this part of the codebase. I am not entirely positive if I understand this correctly tho.
I tried to add an attribute and realize the count attribute was not declared but used, but it actually suppose to be that way.
arthanson
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #505
Add support for SVG elevation diagrams via render='svg' parameter on rack elevation endpoint.
Changes
Request.__init__()(defaults to True)Request._make_call()to set Accept header and parse responses based on expect_jsonROMultiFormatDetailEndpointclass for multiformat responsesROMultiFormatDetailEndpointdocs/advanced.md