fix: response seralize() should counts new properties added by user
#725
Conversation
jnovinger
requested review from
a team and
jeremystretch
and removed request for
a team
|
There might be a related issue here: #586 |
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
Thanks @NeverBehave. I've confirmed the fix but have some suggestions to clean up the logic a bit.
pynetbox/core/response.py
Outdated
| init_vals = None | ||
|
|
||
| # Get all field names from _init_cache | ||
| init_cache_keys = {k for k, v in self._init_cache} |
There was a problem hiding this comment.
Can we not just reference set(self._init_cache.keys())?
There was a problem hiding this comment.
_init_cache is a list a believe, in order to use it as dict, I can wrap it as dict first.
https://stackoverflow.com/questions/6522446/list-of-tuples-to-dictionary
| all_keys = init_cache_keys | obj_keys | ||
|
|
||
| # Create list of tuples for consistency with _init_cache format | ||
| fields_to_serialize = [(k, None) for k in all_keys] |
There was a problem hiding this comment.
Does fields_to_serialize need to contain tuples? It looks like we're discarding the second item in each in the for loop below.
There was a problem hiding this comment.
The value will be refetched anyway by the for loop below, which discard the value.
I am trying to keep minimal changes while patching this.
2 participants
Fixes: #708
init=False, combine fields from both the initial API response and the object's current stateINTERNAL_ATTRSconstant