#532 - move integer BigIntegerField#600
Conversation
|
@claude /review Only report on issues of potential concern; we don't need commentary on anything that doesn't require further consideration. |
|
Claude finished @arthanson's task in 1m 56s —— View job PR Review: #532 - move integer BigIntegerFieldTwo items worth considering: 1. Unquoted identifier in cursor.execute(
f'ALTER TABLE "{table_name}" ALTER COLUMN "{column_name}" TYPE bigint'
)
cursor.execute(
f'ALTER TABLE {schema_editor.quote_name(table_name)} '
f'ALTER COLUMN {schema_editor.quote_name(column_name)} TYPE bigint'
)2. Test passes current app registry instead of historical registry ( from django.apps import apps
...
migration.widen_integer_columns(apps, schema_editor)Django's |
|
Claude issues resolved. |
bctiemann
left a comment
There was a problem hiding this comment.
LGTM, but I feel like this should be into feature for a couple of reasons -- 1) it's technically an expected-behavior change, and 2) it has a migration which will clash with the 0015 that just got merged into feature and will need to be renumbered at some point anyway.
Fixes: #532
Switched IntegerField to BigIntegerField for int fields and supporting migration. I didn't see a reason to keep the IntegerField, NetBox uses BitIntegerField for pretty much everything now.