Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement pktvisor config parser #70

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

leoparente
Copy link
Contributor

This pull request includes several changes to the pktvisor backend in the agent package. The key changes involve updating configuration handling, modifying default settings, and improving error handling. Below are the most important changes:

Configuration Handling:

  • Introduced the creation of a temporary YAML configuration file within the Configure method, including the conversion of the configuration map to YAML and writing it to the temp file. (agent/backend/pktvisor/pktvisor.go)

Default Settings:

  • Removed the defaultConfigPath constant and updated default settings for host and port in RegisterBackendSpecificVariables. (agent/backend/pktvisor/pktvisor.go, agent/backend/pktvisor/vars.go) [1] [2]

Imports and Dependencies:

  • Added new imports for fmt, os, and yaml.v3 to support the new configuration handling logic. (agent/backend/pktvisor/pktvisor.go)

@leoparente leoparente self-assigned this Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.03s github.com/netboxlabs/orb-agent/agent 0.0% 1 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/backend 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/devicediscovery 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/networkdiscovery 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/otel 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/pktvisor 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/backend/worker 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/configmgr 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/policies 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/policymgr 0.0% 0 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/version 100.0% 1 0 0

Total coverage: 0.8%

@leoparente leoparente merged commit 481b931 into develop Mar 7, 2025
5 checks passed
@leoparente leoparente deleted the feat/OBS-816-pktvisor-config-parser branch March 7, 2025 18:33
Copy link

github-actions bot commented Mar 7, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants