Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 49 additions & 3 deletions src/components/table/body/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { memo, useCallback, useRef, useEffect } from "react"
import React, { memo, useCallback, useRef, useEffect, useState } from "react"
import { useVirtualizer, defaultRangeExtractor } from "@tanstack/react-virtual"
import identity from "lodash/identity"
import Flex from "@/components/templates/flex"
Expand Down Expand Up @@ -35,11 +35,38 @@ const Body = memo(
initialOffset = 0,
onScroll,
enableColumnReordering,
deferMeasureMs,
...rest
}) => {
useTableState(rerenderSelector)
const ref = useRef()

const isDeferEnabled = !!deferMeasureMs && deferMeasureMs > 0

const scrollTimeoutRef = useRef(null)
const [measureEnabled, setMeasureEnabled] = useState(true)

const handleScrollDetection = useCallback(() => {
setMeasureEnabled(false)

if (scrollTimeoutRef.current) {
clearTimeout(scrollTimeoutRef.current)
}

scrollTimeoutRef.current = setTimeout(() => {
setMeasureEnabled(true)
}, deferMeasureMs)
}, [deferMeasureMs])

// Cleanup timeout on unmount
useEffect(() => {
return () => {
if (scrollTimeoutRef.current) {
clearTimeout(scrollTimeoutRef.current)
}
}
}, [])

const { rows } = table.getRowModel()

const rowVirtualizer = useVirtualizer({
Expand All @@ -64,6 +91,22 @@ const Body = memo(
}, []),
})

const measureRef = useCallback(
node => {
if (!isDeferEnabled || (measureEnabled && node)) {
rowVirtualizer.measureElement(node)
return
}
},
[isDeferEnabled, measureEnabled, rowVirtualizer]
)

useEffect(() => {
if (isDeferEnabled && measureEnabled) {
rowVirtualizer.measure()
}
}, [isDeferEnabled, measureEnabled, rowVirtualizer])

if (virtualRef) virtualRef.current = rowVirtualizer

const virtualRows = rowVirtualizer.getVirtualItems()
Expand Down Expand Up @@ -99,7 +142,10 @@ const Body = memo(
overflow="auto"
flex="1"
data-testid={`netdata-table${testPrefix}`}
onScroll={onScroll}
onScroll={e => {
if (isDeferEnabled) handleScrollDetection()
if (onScroll) onScroll(e)
}}
>
<div
style={{
Expand All @@ -125,7 +171,7 @@ const Body = memo(
display: "flex",
}}
data-index={virtualRow.index}
ref={rowVirtualizer.measureElement}
ref={measureRef}
>
{virtualRow.index === 0 ? (
<Header
Expand Down
Loading