fix: prevent task list flash on session restore and during conversation#1215
Merged
Conversation
- Initialize autoHidden to true when all tasks are already completed on mount (e.g. session restore), instead of showing for 5 seconds then hiding - Add shallow comparison in onTasksChange callback to skip state updates when tasks haven't materially changed (same id + status), preventing unnecessary re-renders and autoHidden resets that cause flickering - Update tests to reflect new immediate-hide-on-mount behavior and add dedicated test for the all-completed-on-mount case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mount (e.g. session restore), instead of showing for 5 seconds then
hiding
when tasks haven't materially changed (same id + status), preventing
unnecessary re-renders and autoHidden resets that cause flickering
dedicated test for the all-completed-on-mount case