fix: remove selectorJustUsed gate that blocked input after command selection#1216
Merged
Conversation
…lection The selectorJustUsed flag blocked ALL HANDLE_KEY dispatches after closing selectors/views, causing Enter to not send after command selection or view dismissal. The flag was reset via setTimeout(0) which was unreliable. Removed the gate from inputReducer and inputHandlers since specific key handlers already prevent double processing: - Escape: early returns when selectors are active - Enter: swallowed when showCommandSelector/showFileSelector is active Also added internal command routing: when /help, /tasks, etc. are typed directly or Tab-inserted and Enter pressed, they now route to EXECUTE_COMMAND instead of SEND_MESSAGE. Agent commands and unknown /commands still go to SEND_MESSAGE so the full content reaches the agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selectorJustUsed flag blocked ALL HANDLE_KEY dispatches after closing
selectors/views, causing Enter to not send after command selection or view
dismissal. The flag was reset via setTimeout(0) which was unreliable.
Removed the gate from inputReducer and inputHandlers since specific key
handlers already prevent double processing:
Also added internal command routing: when /help, /tasks, etc. are typed
directly or Tab-inserted and Enter pressed, they now route to EXECUTE_COMMAND
instead of SEND_MESSAGE. Agent commands and unknown /commands still go to
SEND_MESSAGE so the full content reaches the agent.