fix: preserve plugin skills when refreshSkills is triggered by file watcher#1222
Merged
Conversation
…atcher SkillManager.refreshSkills() cleared all skills including plugin skills, then discoverSkills() only re-discovered builtin/personal/project skills. This caused plugin skill slash commands (e.g. /commit-skills:commit-push-mr) to become unregistered after any SKILL.md file change triggered a refresh. Fix: store plugin skills in separate pluginSkillMetadata/pluginSkillContent maps so they survive the clear-rediscover cycle in refreshSkills().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a SKILL.md file change triggers
refreshSkills()via the file watcher, all skills including plugin skills were cleared and lost. SincediscoverSkills()only rediscovers builtin/personal/project skills, plugin skill slash commands (e.g./commit-skills:commit-push-mr) became unregistered.Root Cause
SkillManager.refreshSkills()callsskillMetadata.clear()+skillContent.clear()which removes ALL skills. Plugin skills registered viaregisterPluginSkills()are stored in the same maps but not re-discovered bydiscoverSkills().Fix
Store plugin skills in separate
pluginSkillMetadata/pluginSkillContentmaps. AfterrefreshSkills()clears and re-discovers disk-based skills, plugin skills are restored from the plugin-specific maps.Test
Added test verifying plugin skills and their slash commands survive a file watcher triggered refresh.