refactor: remove interval-based (20th message) cache control#1227
Merged
Conversation
This function was only used by the removed interval caching logic.
- Add cache_control to last user message in transformMessagesForClaudeCache - Fix addCacheControlToContent to preserve non-text parts (image_url) and only add cache_control to the last text part (not all text parts) - Add spec User Story 2 and FR-003 for last user message caching - Update tests for new behavior, add 3 new test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the interval-based (20th message) cache control logic to simplify the cache strategy.
Changes
Code (
cacheControlUtils.ts):findIntervalMessageIndexfunctionaddCacheControlToLastToolCallfunction (only used by interval logic)transformMessagesForClaudeCacheTests (
aiService.cacheControl.test.ts):Spec (
spec.md):Spec Companion Files:
Remaining Cache Control
cache_control: { type: "ephemeral" }Testing
All 3078 agent-sdk tests pass.