feat: allow removing built-in marketplace#1230
Merged
Merged
Conversation
Remove the hardcoded protection that prevented deletion of the wave-plugins-official marketplace. The built-in marketplace is now treated like any other cache entry: - removeMarketplace() no longer throws for builtin scope - listMarketplaces() no longer hardcodes builtin injection - getKnownMarketplaces() returns empty list when no cache exists - getMarketplaceDeclaringSource() checks scopes before fallback to builtin Deletion is permanent — no auto-restore on startup. Users can manually restore via wave plugin marketplace add netease-lcap/wave-plugins-official.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow users to permanently delete the built-in
wave-plugins-officialmarketplace, matching Claude Code's non-hardcoded list pattern.Changes
MarketplaceService.tsremoveMarketplace()— removed thethrow "Cannot remove built-in marketplace"; when scope is "builtin", skipsremoveMarketplaceFromScope()but still callsremoveFromCache()listMarketplaces()— removed hardcodedresult.push(BUILTIN_MARKETPLACE)and bothif (name === BUILTIN_MARKETPLACE.name) continue;guards; builtin now appears naturally from cache if presentgetKnownMarketplaces()— returns empty list when no cache file, no longer injects builtingetMarketplaceDeclaringSource()— moved builtin name check after scope checks (fallback to "builtin" only if not in any scope's settings)Test Updates
listMarketplaces()Behavior
wave plugin marketplace add netease-lcap/wave-plugins-officialTesting