Skip to content

Conversation

@camperko
Copy link
Member

@camperko camperko commented Mar 27, 2025

Description

Add option to select multiple init transitions for taskRef field. Transitions are picked from sorted list and saved as chips.

Implements NAB-359 NAB-371

Dependencies

Requires petri.svg 1.1.1 and petriflow.svg 1.1.1

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

Manually tested in builder.

Name Tested on
OS Linux Mint 21
Runtime Node 20.13.1
Dependency Manager npm 10.8.0
Framework version Angular 13.3.1
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @mazarijuraj
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides

mazarijuraj and others added 7 commits November 18, 2024 14:00
- refactor data detail to allow different init type inputs
- refactor into angular component
- reuse component in form builder
- increase version of petri.svg and petriflow.svg libs
- compare init values by transition id if no label is present
@camperko camperko added the improvement New feature or request label Mar 27, 2025
@camperko camperko requested a review from mazarijuraj March 27, 2025 09:48
@camperko camperko self-assigned this Mar 27, 2025
- disable tasks that contain taskRef as dataRef
@mazarijuraj mazarijuraj merged commit 9983fc8 into next Apr 7, 2025
4 of 5 checks passed
@mazarijuraj mazarijuraj deleted the NAB-359 branch April 7, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants