Skip to content

Conversation

@camperko
Copy link
Member

@camperko camperko commented Apr 8, 2025

Description

Arcs which referenced data has non positive integer value will be displayed/represented with value 0 in edit + simulation mode

Fixes NAB-375

Dependencies

No new dependencies were introduced

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

Blocking by PF-79

How Has Been This Tested?

Manually tested in local dev env in running application

Name Tested on
OS Linux Mint 21
Runtime Node 20.13.1
Dependency Manager npm 10.8.0
Framework version Angular 13.3.1
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides

… arcs not to load

- arcs which referenced data has non integer value will be displayed/represented with value 0 in edit + simulation mode
@camperko camperko added the bugfix label Apr 8, 2025
@camperko camperko requested a review from mazarijuraj April 8, 2025 13:13
@camperko camperko self-assigned this Apr 8, 2025
… arcs not to load

- Improved usage of ImportUtils.isInitValueNumber to replace regex checks for initialization values.
@tuplle tuplle merged commit 3c41e30 into next May 14, 2025
3 of 5 checks passed
@tuplle tuplle deleted the NAB-375 branch May 14, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants