Refactor workspace manager permissions and role bindings - #1189
Draft
abellonioandrea wants to merge 2 commits into
Draft
Refactor workspace manager permissions and role bindings#1189abellonioandrea wants to merge 2 commits into
abellonioandrea wants to merge 2 commits into
Conversation
…erRole and migrate existing RoleBindings
Collaborator
|
Hi @abellonioandrea. Thanks for your PR. I am @kingmakerbot.
Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors workspace manager permissions by aggregating them into a single ClusterRole (crownlabs-workspace-manager), rather than creating multiple separate RoleBindings per namespace.
Changes
https://kubernetes.io/docs/reference/access-authn-authz/rbac/#aggregated-clusterroles
This PR is related to #1179