refactor: const-корректность _walk_path — разделение на _walk_path_read и _walk_path_create (Этап 10.4, Issue #208)#225
Merged
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: netkeep80#208
…ad и _walk_path_create (Этап 10.4, Issue netkeep80#208) Шаблонный _walk_path<bool CreateMode>() const разделён на два метода: - _walk_path_read() const — только чтение, возвращает 0 при отсутствии узла - _walk_path_create() — без const, создаёт промежуточные узлы Устранена ложная const-квалификация метода, который в режиме CreateMode=true модифицировал дерево узлов через глобальное состояние PMM. Добавлены 10 тестов в tests/test_pjson_const_correctness.cpp. Обновлены plan.md и readme.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
konard
changed the title
This reverts commit de3e30e.
Contributor
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
🤖 Models used:
📎 Log file uploaded as Gist (1587KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
Contributor
Author
✅ Ready to mergeThis pull request is now ready to be merged:
Monitored by hive-mind with --auto-restart-until-mergeable flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_walk_path<bool CreateMode>() constразделён на два метода с корректными квалификаторами:_walk_path_read() const— только чтение, возвращает 0 при отсутствии узла_walk_path_create()— безconst, создаёт промежуточные узлыconst-квалификация метода, который в режимеCreateMode=trueмодифицировал дерево узлов через глобальное состояние PMMtests/test_pjson_const_correctness.cppplan.mdиreadme.mdКонтекст
Это Этап 10.4 (Проблема 11) из plan.md. Метод
_walk_path<bool>()был объявленconst, но в режимеCreateMode=trueмодифицировал дерево узлов. Это было возможно только из-за глобального состояния PMM. Разделение на два явных метода (_walk_path_readи_walk_path_create) делает const-контракт корректным и устраняетif constexprветвление.Fixes
Fixes #208
Test plan
deps/pmm/pmm.h)🤖 Generated with Claude Code