fix: determine the correct environment variables#6892
Open
petervmeijgaard wants to merge 2 commits intonetlify:mainfrom
Open
fix: determine the correct environment variables#6892petervmeijgaard wants to merge 2 commits intonetlify:mainfrom
petervmeijgaard wants to merge 2 commits intonetlify:mainfrom
Conversation
When creating a new build using the Netlify CLI for a specific branch deploy, it will fail to fetch the correct environment variables and will result in a broken build. Instead of fetching for a specific context, it will fetch all environment variables and determine which ones to use later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #6891
When creating a new build using the Netlify CLI for a specific branch deploy, it will fail to fetch the correct environment variables and will result in a broken build.
Instead of fetching for a specific context, this fix will make sure that all environment variables are fetched first. Next, it will determine the ones to use.
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)