Skip to content

fix: use system logger for bugsnag logger #6927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pieh wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: use system logger for bugsnag logger #6927

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58d7d4a
fix: use system logger for bugsnag logger
pieh Feb 13, 2026
210ac2d
dry-run to test
pieh Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions packages/build/src/error/monitor/start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,16 @@ import Bugsnag from '@bugsnag/js'
import memoizeOne from 'memoize-one'

import type { ResolvedFlags } from '../../core/normalize_flags.js'
import { Logs, log } from '../../log/logger.js'
import { type Logs, getSystemLogger, log } from '../../log/logger.js'
import { ROOT_PACKAGE_JSON } from '../../utils/json.js'
import type { SystemLogger } from '../../plugins_core/types.js'

const projectRoot = fileURLToPath(new URL('../../..', import.meta.url))

// Start a client to monitor errors
export const startErrorMonitor = function (config: { flags: ResolvedFlags; logs?: Logs; bugsnagKey?: string }) {
const {
flags: { mode },
flags: { debug, mode, systemLogFile },
logs,
bugsnagKey,
} = config
Expand All @@ -23,22 +24,28 @@ export const startErrorMonitor = function (config: { flags: ResolvedFlags; logs?

const isTest = isBugsnagTest(bugsnagKey)
const releaseStage = getReleaseStage(mode)
const logger = getLogger(logs, isTest)
const logger = getLogger(getSystemLogger(logs, debug, systemLogFile), isTest)
try {
const errorMonitor = startBugsnag({
apiKey: bugsnagKey,
apiKey: 'aabbccddaabbccddaabbccddaabbccdd',
appVersion: `${ROOT_PACKAGE_JSON.name} ${ROOT_PACKAGE_JSON.version}`,
appType: ROOT_PACKAGE_JSON.name,
releaseStage,
logger,
projectRoot,
endpoints: {
notify: 'http://dry-run:9999/notify', // nothing listening → fast failure
sessions: 'http://dry-run:9999/sessions',
},
})

// Allows knowing the percentage of failed builds per release
if (!isTest) {
errorMonitor.startSession()
}

errorMonitor.notify(new Error('just testing stuff'))
Copy link
Copy Markdown
Contributor

@mrstork mrstork Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can clean up the changes made for testing like this one, this looks good to me


return errorMonitor
// Failsafe
} catch (error) {
Expand All @@ -57,7 +64,7 @@ const BUGSNAG_TEST_KEY = '00000000000000000000000000000000'
// several times.
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
const startBugsnag = memoizeOne(Bugsnag.start.bind(Bugsnag), () => true)
const startBugsnag = memoizeOne(Bugsnag.start.bind(Bugsnag), () => true) as typeof Bugsnag.default.start

// Based the release stage on the `mode`
const getReleaseStage = function (mode = DEFAULT_RELEASE_STAGE) {
Expand All @@ -70,9 +77,9 @@ const DEFAULT_RELEASE_STAGE = 'unknown'
// We also want to use our own `log` utility, unprefixed.
// In tests, we don't print Bugsnag because it sometimes randomly fails to
// send sessions, which prints warning messags in test snapshots.
const getLogger = function (logs, isTest) {
const logFunc = isTest ? noop : log.bind(null, logs)
return { debug: noop, info: noop, warn: logFunc, error: logFunc }
const getLogger = function (systemLogger: SystemLogger, isTest) {
const logFunc = isTest ? noop : log.bind(null, systemLogger)
return { debug: noop, info: noop, warn: logFunc, error: logFunc } satisfies Bugsnag.Logger
}

const noop = function () {
Expand Down
Loading