Skip to content

fix: remove dead logModulesWithDynamicImports#7077

Open
serhalp wants to merge 1 commit into
mainfrom
fix/remove-dead-dynamic-imports-code
Open

fix: remove dead logModulesWithDynamicImports#7077
serhalp wants to merge 1 commit into
mainfrom
fix/remove-dead-dynamic-imports-code

Conversation

@serhalp

@serhalp serhalp commented May 28, 2026

Copy link
Copy Markdown
Member

Summary

This was orphaned years ago by ef4ab12c3.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 97be4040-629c-4ea9-845b-17a3564e7c83

📥 Commits

Reviewing files that changed from the base of the PR and between 42d439a and a78f88d.

📒 Files selected for processing (1)
  • packages/build/src/log/messages/core_steps.js
💤 Files with no reviewable changes (1)
  • packages/build/src/log/messages/core_steps.js

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Removed erroneous warning about dynamic module imports from bundling logs, providing cleaner and more accurate build output.
  • Chores

    • Simplified internal bundling metrics collection.

Walkthrough

This PR removes the dynamic imports warning logging feature from the bundle results handler. The logBundleResults function no longer extracts modulesWithDynamicImports from bundling results, no longer calls the logModulesWithDynamicImports helper to emit the warning, and the helper function itself is deleted. The existing error and warning summary logging remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete; it lacks a proper Summary section with issue reference, motivation, and checklist items required by the repository template. Add issue reference (Fixes #), expand motivation explaining why the code is dead/orphaned, and include the required checklist items for testing and documentation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing dead code for the logModulesWithDynamicImports function, which aligns with the actual changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-dead-dynamic-imports-code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@serhalp serhalp marked this pull request as ready for review May 28, 2026 14:09
@serhalp serhalp requested a review from a team as a code owner May 28, 2026 14:09
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Actionable comments posted: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant