chore: replace half-baked eslint setup with oxlint#610
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e07294f to
bd9b714
Compare
bd9b714 to
2178fa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had set up eslint in this repo after the fact, but in the interest of time we hadn't quite set it up correctly, we hadn't curated plugins and rules to enable, and we had suppressed hundreds of errors.
By now, oxlint is stable and solid: https://oxc.rs/docs/guide/usage/linter.html. And it's extremely fast. So this PR revamps the linting setup to use oxlint.
oxlint has the concept of rule "categories". This PR only enables all the "correctness" rules. These all catch definite errors. We can always add more later.
Tip
The first time you work in a codebase that uses oxlint, you may need to install a new extension in your IDE: https://oxc.rs/docs/guide/usage/linter/editors.html.