NETOBSERV-2194: OCP4.19 uses rhel9.6 which doesn't have rh_psample_sample_packet anymore

[msherif1234]

Description

kernel version older tnan rhel9.6 has temp hook for network events rh_psample_sample_packet
starting from rhel9.6 psample_sample_packet is now available in kapi and rh_ one is removed

This breaking changes which need to be doc.
for users of network events with the upcoming netobserv release 1.9 they have to use OCP4.19 and above.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[msherif1234]

/ok-to-test

[github-actions]

New images:
quay.io/netobserv/ebpf-bytecode:cca09cb
quay.io/netobserv/netobserv-ebpf-agent:cca09cb

These will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=cca09cb make set-agent-image

[codecov]

Codecov Report

Attention: Patch coverage is 1.35135% with 73 lines in your changes missing coverage. Please review.

Project coverage is 27.40%. Comparing base (15d1300) to head (2a16ad6).

Files with missing lines	Patch %	Lines
pkg/tracer/tracer.go	0.00%	72 Missing ⚠️
pkg/ebpf/bpf_x86_bpfel.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
+ Coverage   27.10%   27.40%   +0.30%     
==========================================
  Files          47       47              
  Lines        4988     4977      -11     
==========================================
+ Hits         1352     1364      +12     
+ Misses       3532     3510      -22     
+ Partials      104      103       -1     

Flag	Coverage Δ
unittests	27.40% <1.35%> (+0.30%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/kernel/kernel_utils.go	42.30% <100.00%> (ø)
pkg/ebpf/bpf_x86_bpfel.go	0.00% <0.00%> (ø)
pkg/tracer/tracer.go	0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jotak]

lgtm but please wait for the QE go to make sure it's ok with them - starting from now on, testing net events won't work on 4.18

[msherif1234]

lgtm but please wait for the QE go to make sure it's ok with them - starting from now on, testing net events won't work on 4.18

cc'd @memodi and @Amoghrd

[msherif1234]

/ok-to-test

[github-actions]

New images:
quay.io/netobserv/ebpf-bytecode:6c92bfe
quay.io/netobserv/netobserv-ebpf-agent:6c92bfe

These will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=6c92bfe make set-agent-image

[openshift-ci-robot]

@msherif1234: This pull request references NETOBSERV-2194 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Description

kernel version older tnan rhel9.6 has temp hook for network events rh_psample_sample_packet
starting from rhel9.6 psample_sample_packet is now available in kapi and rh_ one is removed

This breaking changes which need to be doc.
for users of network events with the upcoming netobserv release 1.9 they have to use OCP4.19 and above.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@msherif1234: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/qe-e2e-tests	02a3ed3	link	false	/test qe-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[memodi]

/label qe-approved

verified with networkevents e2e auto.

[openshift-ci-robot]

@msherif1234: This pull request references NETOBSERV-2194 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Description

kernel version older tnan rhel9.6 has temp hook for network events rh_psample_sample_packet
starting from rhel9.6 psample_sample_packet is now available in kapi and rh_ one is removed

This breaking changes which need to be doc.
for users of network events with the upcoming netobserv release 1.9 they have to use OCP4.19 and above.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[msherif1234]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msherif1234]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment