NETOBSERV-2360 Loki dev mode #1801
Conversation
jpinsonneau
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:07f9391 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-07f9391Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-07f9391
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
github-actions
bot
removed
the
ok-to-test
jpinsonneau
added
the
ok-to-test
|
Updated bundle |
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:0492b4c make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-0492b4cOr as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-0492b4c
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:7ea9054 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-7ea9054Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-7ea9054
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
jpinsonneau
force-pushed
the
loki-dev
branch
from
cac503f to
4575734
Compare
github-actions
bot
removed
the
ok-to-test
|
Rebased without changes |
jpinsonneau
force-pushed
the
loki-dev
branch
from
4575734 to
167442a
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
Amoghrd
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
jpinsonneau
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:e902b6c make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-e902b6cOr as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-e902b6c
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
e2e-operator test is failing here with FLP not being able to come ready, does the test needs to be updated or something that needs be updated in PR? |
| name: console-plugin | ||
| - image: quay.io/netobserv/network-observability-console-plugin:v1.10.0-community-pf4 | ||
| name: console-plugin-compat | ||
| - image: grafana/loki:3.5.0 |
There was a problem hiding this comment.
I'm still pretty sure this is going to fail konflux validation of the related images, as this isn't an approved registry
There was a problem hiding this comment.
The corresponding image downstream should be https://catalog.redhat.com/en/software/containers/openshift-logging/logging-loki-rhel9/64479926a759a6e51ef79b12
I need to test it to see how it goes 🤔
Maybe we should make this configurable so we don't force a specific container image and default to the logging one if it works fine ?
There was a problem hiding this comment.
By the way, all of our upstream content points to quay.io so I don't see the issue here.
If you don't want to point grafana/loki image, I can copy it under quay.io/netobserv but that should be the exact same image upstream.
Konflux should replace that image downstream (by the logging one or another we build ourself).
There was a problem hiding this comment.
I confirm it works with image registry.redhat.io/openshift-logging/logging-loki-rhel9:v3.5.7 👌
There was a problem hiding this comment.
By the way, all of our upstream content points to quay.io so I don't see the issue here.
If you don't want to point grafana/loki image, I can copy it under quay.io/netobserv but that should be the exact same image upstream.
Sorry I didn't mean that, for upstream it's ok to have the grafana image, my concern really is about how that would work downstream. See next point:
Konflux should replace that image downstream (by the logging one or another we build ourself).
It's actually something done here: https://github.com/netobserv/network-observability-operator/blob/main/hack/patch_csv.py#L82-L90 So we need to update that file for Loki.
It's nice that logging-loki-rhel9 works as a drop-in replacement, so we can reference it there, but then we need to see how that will work with konflux & renovate: if renovate is able to update it, we can use a pinned digest; if renovate cannot do it then I guess we should use a stream reference (3.5 currently) but that means having to regularly check for updates manually. (And I'm not sure if konflux will accept the non-digest version). Last option could be to disable the feature for downstream builds.
There was a problem hiding this comment.
(I'm asking renovate folks in slack)
|
IMO there should be a systematic warning triggered by the validation webhook, that this isn't supported. Or maybe, at least when there's the DOWNSTREAM_DEPLOYMENT flag (it's ok for upstream) |
github-actions
bot
removed
the
ok-to-test
jpinsonneau
force-pushed
the
loki-dev
branch
from
76c306a to
4686031
Compare
jpinsonneau
added
the
ok-to-test
|
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:59555bd make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-59555bdOr as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-59555bd
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
github-actions
bot
removed
the
ok-to-test
jpinsonneau
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:1791d6e make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-1791d6eOr as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-1791d6e
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
@jpinsonneau: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Implement a new loki mode
Devthat deploy the zero click loki.Also took the opportunity to update the config to rely on latest release using tsdb.
TODOs:
registry.redhat.io/openshift-logging/logging-loki-rhel9:v3.4.3without effortconfig.fileis exposed as container ARG to support downstream imageDependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.