Security: Fix workflow permissions, log injection, and document alerts #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Workflow hardening (.github/workflows/container-test.yml):
- Add explicit 'contents: read' permissions
- Pin action SHAs for supply chain security:
* actions/[email protected]
* docker/[email protected]
2. Log injection fix (src/dashboard/static/js/dashboard.js):
- Add sanitizeForLog() function to prevent log injection
- Sanitize WebSocket message data before logging
- Remove control characters and limit log length
3. CodeQL configuration (.github/codeql/codeql-config.yml):
- Document accepted risks for intentional debug features
- Note stale alerts for removed files
- Configure security-extended queries
Alert Analysis:
- py/clear-text-logging-sensitive-data: False positive - secrets masked by default
- py/jinja2/autoescape-false: Stale alerts for removed files
- py/overly-permissive-file: Test code on temp directories
- js/log-injection: Fixed with sanitizeForLog()
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Remove console.log statements that logged user-controlled WebSocket data. CodeQL flagged these as log injection vulnerabilities (CWE-117). Instead of sanitizing and logging, simply ignore the debug messages since they're not critical for production operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
1. Workflow Hardening
File:
.github/workflows/container-test.ymlpermissions: contents: readactions/[email protected]docker/[email protected]2. Log Injection Fix (CWE-117)
File:
src/dashboard/static/js/dashboard.jsWebSocket message data was being logged directly to console, allowing potential log injection attacks.
Fix: Added
sanitizeForLog()function that:\x00-\x1F\x7F)3. Alert Documentation
File:
.github/codeql/codeql-config.ymlDocuments why certain alerts are accepted risks:
Test Plan