feat(core): ExecJob console-height / console-width for TTY sizing (#235)

[CybotTM]

Summary

Operators can now configure the initial pseudo-TTY console size for job-exec jobs via two new fields:

```ini
[job-exec "my-job"]
tty = true
console-height = 24
console-width = 80
```

Useful for jobs that render TUIs, tables, or formatted text — applications that expect a specific terminal geometry (`htop`, `vim`, formatted reports) now render correctly instead of relying on Docker's default console size.

Closes #235.

Backward compatibility

• Default behavior unchanged: existing configs without `console-height` / `console-width` produce nil `ConsoleSize` on the Docker call (Docker daemon picks the default).
• Only honored when `tty = true`; otherwise the Docker daemon silently ignores the size.
• Requires Docker API v1.42+ (Docker Engine 20.10+, released 2020-12). Ofelia's auto-negotiation handles older daemons gracefully — the field is just ignored.

Tests (5 new)

• `ConsoleSize_NilWhenUnset` — pre-Add ConsoleSize support for TTY-based ExecJobs #235 default preserved when both dimensions are zero.
• `ConsoleSize_HeightWidthOrder` — pins the `[height, width]` order Docker expects (swapping would produce silently-wrong TUI geometry).
• `ConsoleSize_PartialPopulates` — setting only one dimension still produces a non-nil `ConsoleSize` (partial config is operator-meaningful).
• `RunWithStreams_PropagatesConsoleSize` — end-to-end via mock provider, asserts the value reaches `domain.ExecConfig`.
• `RunWithStreams_DefaultsToNilConsoleSize` — legacy "Docker default" behavior preserved when fields are unset.

Test plan

• `go test ./...` passes (full repo, 14 packages, ~58s)
• `golangci-lint run` clean
• `go vet ./...` clean
• CI green

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[github-actions]

Automated approval for maintainer PR

All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.

[github-actions]

✅ Mutation Testing Results

Mutation Score: 100.00% (threshold: 60%)

✨ Good job! Mutation score meets the threshold.

What is mutation testing?

Mutation testing measures test quality by introducing small changes (mutations) to the code and checking if tests detect them. A higher score means better test effectiveness.

• Killed mutants: Tests caught the mutation (good!)
• Survived mutants: Tests missed the mutation (needs improvement)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.08%. Comparing base (44d79cb) to head (eaf7527).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
- Coverage   88.10%   88.08%   -0.03%     
==========================================
  Files          89       89              
  Lines       11497    11504       +7     
==========================================
+ Hits        10130    10133       +3     
- Misses       1115     1117       +2     
- Partials      252      254       +2     

Flag	Coverage Δ
integration	88.08% <100.00%> (-0.03%)	⬇️
unittests	85.43% <100.00%> (+0.10%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Adds operator-configurable initial pseudo-TTY console size (console-height / console-width) to job-exec, plumbed through domain.ExecConfig to Docker's ContainerExecCreate.ConsoleSize. Defaults preserve pre-fix behavior (nil → Docker default).

Changes:

• Add ConsoleHeight / ConsoleWidth fields on ExecJob and a consoleSize() helper that returns nil when both are zero, populating ExecConfig.ConsoleSize on both Run and RunWithStreams paths.
• Extend domain.ExecConfig with ConsoleSize *[2]uint and forward it through the Docker adapter to containertypes.ExecOptions.
• Add unit/integration tests pinning [height, width] order, partial-population semantics, and the nil-default backward-compat path; CHANGELOG entry under Added.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
core/execjob.go	New ConsoleHeight/ConsoleWidth fields, consoleSize() helper, and wiring into both exec config builders.
core/domain/exec.go	Adds ConsoleSize *[2]uint to the domain ExecConfig.
core/adapters/docker/exec.go	Propagates config.ConsoleSize to containertypes.ExecOptions.
core/execjob_console_size_test.go	New tests covering nil default, [height,width] ordering, partial population, and end-to-end propagation.
CHANGELOG.md	Documents the new fields under Added.

[gemini-code-assist]

Code Review

This pull request introduces the ability to set the initial pseudo-TTY console size for job-exec jobs via new console-height and console-width configuration fields. The changes include updates to the ExecJob and ExecConfig structures, the Docker adapter to pass these dimensions to the Docker API, and a new test suite to ensure correct behavior and backward compatibility. I have no feedback to provide.

[github-actions]

Automated approval for maintainer PR

All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.

[CybotTM]

Multi-axis review summary (code-reviewer + test-engineer + Copilot)

All findings applied across one fixup commit (86bc573). 0 unresolved threads.

Applied — Important / High

• Adapter-level SDK boundary test (test-engineer High) — added two TestExecServiceAdapter_Create_* tests using httptest to capture the request body. The containertypes.ExecOptions.ConsoleSize line in exec.go:64 was previously the only untested layer; a refactor dropping it would have passed all 5 core-level tests because they only exercise the mock provider.
• Docs gap (code-reviewer Important + Copilot) — console-height / console-width now documented in docs/jobs.md (exec Parameters section, next to tty) and docs/CONFIGURATION.md (job-exec INI block).

Applied — Medium

• TTY=false propagation test (test-engineer + code-reviewer) — TestExecJob_RunWithStreams_PropagatesConsoleSizeEvenWhenTTYFalse pins that Ofelia owns the wire-the-value layer; the Docker daemon owns the TTY-gating. Prevents a future well-meaning if j.TTY { ... } from silently swallowing operator intent.

Applied — Doc/Suggestion

• consoleSize() partial-values comment (code-reviewer Suggestion) — notes that {40, 0} is intentionally forwarded so the daemon honors the 40 and uses its default for the zero dimension; only "both zero" collapses to nil.

Deferred — with rationale on threads

• TTY-mismatch validation warning (code-reviewer + Copilot Suggestion) — would require plumbing through to config_validate.go's validator chain and a breaking-vs-warning behavioral decision. Scope creep for a small Docker-field addition. The field godoc already documents the daemon-silently-ignores contract, and the new TTY=false test pins it.
• Upper-bound sanity check (code-reviewer Suggestion) — Docker validates daemon-side; uint type already prevents negatives.

Final stats: 7 tests (5 core + 2 adapter), 2 doc files updated, CHANGELOG entry. All 2 inline AI threads replied + resolved.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Automated approval for maintainer PR

All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.