chore(zizmor): drop the local policy copy, the reusable supplies it - #783
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
=======================================
Coverage 89.28% 89.28%
=======================================
Files 88 88
Lines 12147 12147
=======================================
Hits 10846 10846
Misses 1001 1001
Partials 300 300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
Pull request overview
Updates the documentation comments in the zizmor configuration to accurately describe what the unpinned-uses rule enforces (ref-pinned vs SHA-pinned), while clearly separating tooling guarantees from human convention.
Changes:
- Clarifies that first-party
uses:entries are allowed to be pinned to a ref (branch/tag), not necessarily a full commit SHA. - Explicitly states that the specific ref choice (commonly
@main) is a convention enforced by review, not by zizmor.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Automated approval for maintainer PR
All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.
netresearch/.github#339 makes the zizmor reusable fetch the organisation policy at run time when a repo has no .github/zizmor.yml of its own, and removes the file from the templates. Keeping a copy here would silently win over the shared policy the next time it really changes, which is how this file came to differ across the fleet in the first place. The scan itself is unchanged: the same policy is applied, from one place. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
CybotTM
force-pushed
the
chore/sync-zizmor-comment
branch
from
August 2, 2026 17:51
d889c42 to
e0c6cc0
Compare
CybotTM
changed the title
|
There was a problem hiding this comment.
Automated approval for maintainer PR
All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 2, 2026
CybotTM
added a commit
to netresearch/.github
that referenced
this pull request
Aug 2, 2026
…#340) GitHub deletes the `gh-readonly-queue` ref the moment a merge queue finishes, which races the SARIF upload inside `codeql-action/analyze`. `scorecard.yml` already guards against this and its comment calls the result "a guaranteed `ref ... not found` failure"; `zizmor.yml` skips its whole job for the same reason. `codeql.yml` never got the guard. The consequence is not a cosmetic red check: the queue run fails, and `github-merge-queue[bot]` **ejects the pull request from the queue**. It happened on [netresearch/ofelia#783](netresearch/ofelia#783), a pull request that deletes one YAML file and touches no Go code at all — added to the queue at 18:40:42, removed at 18:46:13, with `codeql / Analyze (go)` reporting `ref 'refs/heads/gh-readonly-queue/main/pr-783-...' not found in this repository`. Every merge-queue repository that calls this reusable is exposed to the same race. No analysis coverage is lost. The pull-request head is analysed before it ever reaches the queue, and the `push` and `schedule` events that keep the default-branch results current run against stable refs — which is exactly the reasoning already written down in `scorecard.yml`.
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
.github/zizmor.yml. netresearch/.github#339 makes the zizmor reusable fetch the organisation policy at run time when a repo has no file of its own, and drops it from all five templates, so this copy no longer has a job.It is not harmless to leave behind. A local file takes precedence over the fetched one, so this repository would keep running an old policy the next time the shared one actually changes — which is exactly how a two-line policy ended up needing a pull request in 54 repositories to reword a comment.
The scan result does not change: the same policy is applied, from one place instead of 54. A repository that genuinely needs a different policy opts out by keeping its own
.github/zizmor.yml; this one was byte-identical to the template, which was verified before deleting.This pull request previously carried the comment rewording from #336. That became pointless once the file itself moved, so the branch was rewritten to delete it instead.