Skip to content

fix: set minimum-stability dev for DDEV path repositories - #109

Merged
CybotTM merged 1 commit into
mainfrom
fix/ddev-composer-stability
Mar 9, 2026
Merged

fix: set minimum-stability dev for DDEV path repositories#109
CybotTM merged 1 commit into
mainfrom
fix/ddev-composer-stability

Conversation

@CybotTM

@CybotTM CybotTM commented Mar 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Path repositories (nr-vault, nr-llm) serve dev-stability packages (dev-main alias 0.4.x-dev)
  • TYPO3 base distribution defaults to minimum-stability: stable, rejecting dev packages
  • Adds composer config minimum-stability dev + prefer-stable true before requiring extensions

Test plan

  • make up completes successfully with ddev install-v14
  • Both nr-vault and nr-llm are symlinked from path repos

Path repositories serve dev-stability packages (dev-main alias),
which fails when TYPO3 base distribution defaults to stable.

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Copilot AI review requested due to automatic review settings March 9, 2026 21:08
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where DDEV path repositories, serving development-stability packages, conflicted with TYPO3's default Composer minimum-stability: stable setting. The changes configure Composer to correctly handle these development packages while still preferring stable versions, ensuring successful installation of required extensions within the DDEV environment.

Highlights

  • Composer Configuration: Configured Composer to allow dev stability packages by setting minimum-stability to dev and prefer-stable to true.
  • DDEV Path Repositories: Ensured compatibility for DDEV path repositories (like nr-vault and nr-llm) which provide dev-main packages, resolving conflicts with TYPO3's default minimum-stability: stable.
Changelog
  • .ddev/commands/web/install-v14
    • Added Composer commands to set minimum-stability to dev and prefer-stable to true before requiring extensions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@CybotTM
CybotTM added this pull request to the merge queue Mar 9, 2026
Merged via the queue into main with commit 04acede Mar 9, 2026
40 checks passed
@CybotTM
CybotTM deleted the fix/ddev-composer-stability branch March 9, 2026 21:08
@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval for solo maintainer project

This PR has passed all automated quality gates:

  • ✅ Static analysis (PHPStan)
  • ✅ Code style (PHP-CS-Fixer)
  • ✅ Unit & functional tests
  • ✅ Security scanning
  • ✅ Dependency review

See SECURITY_CONTROLS.md for compensating controls documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the DDEV install-v14 script to accommodate dev-stability packages served by path repositories (nr-vault, nr-llm). Since TYPO3's base distribution defaults to minimum-stability: stable, Composer rejects dev-main / 0.4.x-dev packages from path repos. The fix sets minimum-stability dev and prefer-stable true before requiring the extensions.

Changes:

  • Adds composer config minimum-stability dev and composer config prefer-stable true before the path repository configuration and composer require in install-v14.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +38 to +39
composer config minimum-stability dev
composer config prefer-stable true

Copilot AI Mar 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same minimum-stability dev / prefer-stable true fix is missing from .ddev/commands/web/install-v13 (lines 38-40), which has the identical pattern of adding path repositories and then composer require netresearch/nr-llm:@dev. If v13's base distribution also defaults to minimum-stability: stable, it will fail in the same way. Consider applying this fix to install-v13 as well for consistency.

Copilot uses AI. Check for mistakes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses an issue with installing development-stability packages from path repositories by adjusting Composer's minimum-stability setting. The change is logical and well-placed within the installation script. I have one suggestion to improve the script's robustness.

Comment on lines +38 to +39
composer config minimum-stability dev
composer config prefer-stable true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve script robustness, it's good practice to chain related commands using &&. This ensures that subsequent commands only execute if the preceding ones are successful. You can combine these two composer config calls into a single line.

Suggested change
composer config minimum-stability dev
composer config prefer-stable true
composer config minimum-stability dev && composer config prefer-stable true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants