fix: set minimum-stability dev for DDEV path repositories - #109
Conversation
Path repositories serve dev-stability packages (dev-main alias), which fails when TYPO3 base distribution defaults to stable. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where DDEV path repositories, serving development-stability packages, conflicted with TYPO3's default Composer Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Automated approval for solo maintainer project
This PR has passed all automated quality gates:
- ✅ Static analysis (PHPStan)
- ✅ Code style (PHP-CS-Fixer)
- ✅ Unit & functional tests
- ✅ Security scanning
- ✅ Dependency review
See SECURITY_CONTROLS.md for compensating controls documentation.
There was a problem hiding this comment.
Pull request overview
This PR fixes the DDEV install-v14 script to accommodate dev-stability packages served by path repositories (nr-vault, nr-llm). Since TYPO3's base distribution defaults to minimum-stability: stable, Composer rejects dev-main / 0.4.x-dev packages from path repos. The fix sets minimum-stability dev and prefer-stable true before requiring the extensions.
Changes:
- Adds
composer config minimum-stability devandcomposer config prefer-stable truebefore the path repository configuration andcomposer requireininstall-v14.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| composer config minimum-stability dev | ||
| composer config prefer-stable true |
There was a problem hiding this comment.
The same minimum-stability dev / prefer-stable true fix is missing from .ddev/commands/web/install-v13 (lines 38-40), which has the identical pattern of adding path repositories and then composer require netresearch/nr-llm:@dev. If v13's base distribution also defaults to minimum-stability: stable, it will fail in the same way. Consider applying this fix to install-v13 as well for consistency.
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue with installing development-stability packages from path repositories by adjusting Composer's minimum-stability setting. The change is logical and well-placed within the installation script. I have one suggestion to improve the script's robustness.
| composer config minimum-stability dev | ||
| composer config prefer-stable true |
There was a problem hiding this comment.
To improve script robustness, it's good practice to chain related commands using &&. This ensures that subsequent commands only execute if the preceding ones are successful. You can combine these two composer config calls into a single line.
| composer config minimum-stability dev | |
| composer config prefer-stable true | |
| composer config minimum-stability dev && composer config prefer-stable true |
Summary
dev-mainalias0.4.x-dev)minimum-stability: stable, rejecting dev packagescomposer config minimum-stability dev+prefer-stable truebefore requiring extensionsTest plan
make upcompletes successfully withddev install-v14