docs: functional/CI lessons — compile-fatal cascades, private-service get(), per-file coverage, JIT-off for functional, per-leg resolution - #118
Merged
Conversation
…rvice get(), per-file coverage, JIT-off for functional, per-leg resolution - exit 255 cascades are one compile fatal, never flaky infra; rerun replays the old SHA; self-referencing-const trap after literal extraction - FunctionalTestCase::get() resolves private services via the private_container fixture — never public:true just for tests (45->27 publics verified green) - combined-run coverage under-counts mock-exercised classes — measure per file before any architecture decision - functional suites segfault silently under opcache.jit=1255 (exit 139); run them JIT-less, keep JIT for static tools - fresh-worktree no-plugins PHPStan: spurious InvocationStubber errors, stash-baseline verification - no-lock libraries resolve per PHP matrix leg — re-resolve per leg before claiming green Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
github-actions
Bot
added
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Six promoted learnings (
/retro promote, batch 7) across five references:test-environment-guards.md: the setUp-error cascade shape also comes from a PHP compile fatal — PHPUnit exit 255 is a bootstrap fatal, never flaky infra;gh run rerunreplays the original SHA so it cannot disprove a since-fixed break; the self-referencing-constant trap after literal→const sweeps.functional-testing.md:FunctionalTestCase::get()resolves private services (theprivate_containerfixture registers them into a public locator) — neverpublic: truejust for tests; verified 45→27 public services, zero test changes. Plus: combined-run coverage under-counts mock-exercised classes — measure per test file (measured: 0/12 combined vs 11/12 isolated) before any test-architecture decision.test-runners.md(corrects existing guidance): container PHP withopcache.jit=1255segfaults silently (exit 139) during functional bootstrap on valid source — run functional suites JIT-less (PHP_FUNCTIONAL_OPTSwithout JIT), keep JIT for the static tools. Includes the probe/stash-bisect diagnosis pattern.quality-tools.md: the no-plugins fallback without explicit includes produces spuriousInvocationStubber::with()PHPStan errors — verify via controlled stash baseline.ci-cd.md: no-lock libraries resolve per PHP matrix leg — re-resolve per leg (composer config platform.php …) before claiming green.Came from /retro: yes