CodeQL fixes #17
Merged
CodeQL fixes #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squash CodeQL `cpp/unsigned-difference-expression-compared-zero`
issues.
This rule finds relational comparisons between the result of
an unsigned subtraction and the value `0`. Such comparisons
are likely to be wrong as the value of an unsigned subtraction
can never be negative. So the relational comparison ends up
checking whether the result of the subtraction is equal to 0.
This is probably not what the programmer intended.
Squash CodeQL `cpp/unsigned-difference-expression-compared-zero`
issue.
This rule finds relational comparisons between the result of
an unsigned subtraction and the value `0`. Such comparisons
are likely to be wrong as the value of an unsigned subtraction
can never be negative. So the relational comparison ends up
checking whether the result of the subtraction is equal to 0.
This is probably not what the programmer intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few CodeQL issues.