Add FbGetSCCMAdmins (plus other refactors)#1
Open
rasta-mouse wants to merge 7 commits intonettitude:mainfrom
Open
Add FbGetSCCMAdmins (plus other refactors)#1rasta-mouse wants to merge 7 commits intonettitude:mainfrom
rasta-mouse wants to merge 7 commits intonettitude:mainfrom
Conversation
Use raw const strings
- Add CommandName as get-only property on ICommand. - Refactor existing commands. - Change CommandCollection to load commands via Reflection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR was to add
FbGetSCCMAdminswhich reads the site administrative users fromSMS_Admin. Example output:It also includes some other refactoring and code clean-ups (mostly to satisfy my own OCD, for which I apologise). The main functional change is to add
CommandNameas a get-only property onICommand. This way, it is enforced on the command classes, rather than leaving it to the dev to remember. TheCommandCollectionclass now also uses reflection to instantiate each command class, rather than having to manually add each to a dictionary.