This repository was archived by the owner on May 8, 2026. It is now read-only.
Backward Compatible - Http3SettingsFrame abstraction (#15835) - #353
Merged
Conversation
* [x] Provide a cleaner, more maintainable implementation of `Http3SettingsFrame`. * [x] Replace the previous untyped `LongObjectHashMap`-based approach with a typed `Http3Settings` abstraction. * [x] Improve API clarity and future extensibility for HTTP/3 settings handling (similar to Http2Settings) --- * [x] Introduced `Http3Settings` class to encapsulate and manage HTTP/3 settings. * [x] Deprecated legacy untyped accessors (`get()`, `put()`) in favor of typed methods such as `qpackMaxTableCapacity()` and `enableConnectProtocol()`. * [x] Updated `DefaultHttp3SettingsFrame` to use the new `Http3Settings` internally. * [x] Added detailed Javadoc to guide migration to the new typed API. * [x] Added comprehensive test coverage for `Http3Settings` and its integration with `Http3SettingsFrame`. --- * [x] **Backward-compatible** – existing code using `get()`/`put()` still works (marked deprecated). * [x] **Forward-compatible** – encourages use of typed accessors. * [x] **No behavioral change** – internal structure and API clarity improved only. --- Port of netty/netty#15835
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Http3SettingsFrame.LongObjectHashMap-based approach with a typedHttp3Settingsabstraction.Http3Settingsclass to encapsulate and manage HTTP/3 settings.get(),put()) in favor of typed methods such asqpackMaxTableCapacity()andenableConnectProtocol().DefaultHttp3SettingsFrameto use the newHttp3Settingsinternally.Http3Settingsand its integration withHttp3SettingsFrame.get()/put()still works (marked deprecated).Port of netty/netty#15835