Skip to content

Release buffer when serialization throws exception #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
normanmaurer merged 1 commit into from
Jul 26, 2025
Merged

Release buffer when serialization throws exception #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions codec-ohttp/src/main/java/io/netty/incubator/codec/ohttp/OHttpServerCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
import io.netty.buffer.Unpooled;
import io.netty.channel.ChannelFutureListener;
import io.netty.channel.ChannelHandlerContext;
import io.netty.handler.codec.DecoderException;
import io.netty.handler.codec.EncoderException;
import io.netty.handler.codec.http.DefaultFullHttpResponse;
import io.netty.handler.codec.http.DefaultHttpContent;
import io.netty.handler.codec.http.DefaultHttpRequest;
Expand Down Expand Up @@ -235,14 +233,18 @@ protected final void encode(ChannelHandlerContext ctx, HttpObject msg, List<Obje
}
if (oHttpContext != null) {
boolean isLast = msg instanceof LastHttpContent;
ByteBuf contentBytes = ctx.alloc().buffer();
try {
ByteBuf contentBytes = ctx.alloc().buffer();
oHttpContext.serialize(ctx.alloc(), msg, contentBytes);
// Use the correct version of HttpContent depending on if it was the last or not.
HttpContent content = isLast ? new DefaultLastHttpContent(contentBytes) :
new DefaultHttpContent(contentBytes);
out.add(content);
contentBytes = null;
} finally {
if (contentBytes != null) {
contentBytes.release();
}
if (isLast && oHttpContext.sendLastHttpContent()) {
destroyContext();
}
Expand Down
Loading