This repository was archived by the owner on Apr 3, 2025. It is now read-only.
Fix SubmissionQueue.addTimeout(...) #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We did not correctly fill the submission entry for IORING_OP_TIMEOUT which could lead to timeouts firing to early. We need to use a count of 1 when submitting these as we want to notify once either there is one completion ready to process or when the timeout elapsed. Modifications: Correctly fill submission entry Result: IoUringEventLoop.run() will block for the correct amount of time. This is a port of netty/netty#14712
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We did not correctly fill the submission entry for IORING_OP_TIMEOUT which could lead to timeouts firing to early. We need to use a count of 1 when submitting these as we want to notify once either there is one completion ready to process or when the timeout elapsed.
Modifications:
Correctly fill submission entry
Result:
IoUringEventLoop.run() will block for the correct amount of time.
This is a port of netty/netty#14712