Skip to content

Do not delete the authentication method local reference twice #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fredericgermain wants to merge 1 commit into from
Closed

Do not delete the authentication method local reference twice #1002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions openssl-dynamic/src/main/c/sslcontext.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1638,6 +1638,9 @@ static int SSL_cert_verify(X509_STORE_CTX *ctx, void *arg) {
result = (*e)->CallIntMethod(e, c->verifier, c->verifier_method, P2J(ssl), array, authMethodString);

NETTY_JNI_UTIL_DELETE_LOCAL(e, authMethodString);
// NULL it out: every exit from here runs the complete: block below, and deleting the same
// local reference twice is a fatal error under -Xcheck:jni.
authMethodString = NULL;

if ((*e)->ExceptionCheck(e)) {
// We always need to set the error as stated in the SSL_CTX_set_cert_verify_callback manpage, so set the result
Expand Down Expand Up @@ -1770,6 +1773,9 @@ enum ssl_verify_result_t tcn_SSL_cert_custom_verify(SSL* ssl, uint8_t *out_alert
result = (*e)->CallIntMethod(e, state->ctx->verifier, state->ctx->verifier_method, P2J(ssl), array, authMethodString);

NETTY_JNI_UTIL_DELETE_LOCAL(e, authMethodString);
// NULL it out: every exit from here runs the complete: block below, and deleting the same
// local reference twice is a fatal error under -Xcheck:jni.
authMethodString = NULL;

if ((*e)->ExceptionCheck(e) == JNI_TRUE) {
result = X509_V_ERR_UNSPECIFIED;
Expand Down
Loading