Fixes import type not loading error #249
Open
+12
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravindpudayoor
requested review from
Dhruv051925,
atifbonterra,
Copilot,
ganeshmohan2021,
imvishi and
kcpavan
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the "import type not loading" error by ensuring safe calls on potentially nil objects and enforcing consistent key usage in session data.
- Updated view template to use safe navigation for file_origination_type methods
- Standardized hash key lookups in the import_data_controller to use strings
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/views/nfg_csv_importer/imports/show.html.haml | Uses safe navigation operator (&.) for method calls to prevent errors on nil values |
| app/controllers/nfg_csv_importer/onboarding/import_data_controller.rb | Updates key lookups in session data to consistently use string keys to avoid type mismatches |
ganeshmohan2021
approved these changes
Jun 20, 2025
Collaborator
|
Please fix the failing specs |
atifbonterra
approved these changes
Jun 20, 2025
atifbonterra
left a comment
atifbonterra
left a comment
There was a problem hiding this comment.
LGTM, Please fix the failing specs
kcpavan
reviewed
Jun 20, 2025
Collaborator
kcpavan
left a comment
kcpavan
left a comment
There was a problem hiding this comment.
Won't this changes affect DM ?
Author
@kcpavan If we proceed with this branch in FP, it won't affect DM. Otherwise, it may affect. |
added 8 commits
June 20, 2025 15:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.