Correctly manage the life cycle of FD files on the recvfd client side #1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
force-pushed
the
fix-recvfd-client
branch
from
0dfb9aa to
a99d075
Compare
Signed-off-by: Denis Tingaikin <[email protected]>
denis-tingaikin
force-pushed
the
fix-recvfd-client
branch
from
a99d075 to
55a972d
Compare
Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: Denis Tingaikin <[email protected]>
denis-tingaikin
force-pushed
the
fix-recvfd-client
branch
from
476cca4 to
f1124ea
Compare
denis-tingaikin
changed the title
denis-tingaikin
requested review from
NikitaSkrynnik,
VitalyGushin,
ljkiraly and
szvincze
Member
Author
|
The problem is not reproducing on production enviroment, so let's hold it in draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At this moment, each time the forwarder resolves new endpoints on the node, it gets the fd of the unix socket of the endpoint and never deletes it.
This PR fixes the problem via using nse expiration time.
Issue link
Fixes memory leak in
pprof.forwarder.alloc_objects.alloc_space.inuse_objects.inuse_space.031.pb.gz
How Has This Been Tested?
Types of changes