Add RUNNING_CONFIG_MAPPER and get_running_config_command with tests #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kat-git-hub
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
jeffkala
reviewed
Apr 23, 2025
|
Thanks @kat-git-hub think I'm good with this. @itdependsnetworks any concerns. I've considering saying it should be the full command |
jeffkala
approved these changes
May 14, 2025
|
I'm good with it as is. |
itdependsnetworks
approved these changes
May 14, 2025
|
@kat-git-hub we enabled the checks now and CI is failing black. Mind getting that fixed and then we can merge. Thanks again for the contribution! |
|
Thanks! That’s a reasonable point about |
|
Ok,ok. I’ve tested this branch in my fork, and all checks have passed successfully. This change should work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added RUNNING_CONFIG_MAPPER with common platform commands. Created function get_running_config_command(). Added unit tests.
Fixes #622