Normalize pvid with vlan_id #2019
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbear
force-pushed
the
normalize_pvid_with_vlan_id
branch
from
fd03db2 to
aaf30b2
Compare
|
Rebased off of current upstream state to resolve merge conflicts. 😀 |
mjbear
force-pushed
the
normalize_pvid_with_vlan_id
branch
from
c3c2d27 to
dc5912c
Compare
mjbear
force-pushed
the
normalize_pvid_with_vlan_id
branch
from
edb7051 to
130d214
Compare
mjbear
force-pushed
the
normalize_pvid_with_vlan_id
branch
from
130d214 to
6b1a151
Compare
mjbear
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given PRs that have come in, I noticed that some of the hp_comware templates used
PVIDfor the VLAN ID instead ofVLAN_ID. I decided to adjust that with this PR.This is along the same vein as PR #1984 and consequently will cause a merge conflict on
data_model.md. I'll fix that once we merge more PRs in.🗒️ Note: Several of these same templates use
NAMEfor the port description. Though I'm not sure how many of those we should consider normalizing since NAME is pretty common and pattern replaces en masse could be more of a pain than the benefit.The normalization is probably like anything else - work on those with the highest reward first where it makes sense. 😉