Skip to content

Fix XR7 parse error where ARP EVPN line exists #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

garymccann
Copy link
Contributor

Fixes an IOS-XR version 7 issue, where a line is now included for ARP EVPN

@mjbear
Copy link
Collaborator

mjbear commented Apr 1, 2025

Hi @garymccann
I made a couple of adjustments.

  • Regenerated structured data so the keys are in alphabetical order
  • Replaced literal spaces with regexes
  • Replaced a few singular whitespace regexes with a more flexible whitespace regex (one or more)

Thank you!

@garymccann
Copy link
Contributor Author

hey @mjbear - can you please break these adjustments into their own PR - i do not like touching files unrelated to the feature, increasing the blast radius and while i don't see anything wrong with changing the order, it may confuse folk who are using the raw data, since it does not follow any alphabetical ordering. I will revert these PR changes.

@mjbear
Copy link
Collaborator

mjbear commented Apr 2, 2025

hey @mjbear - can you please break these adjustments into their own PR - i do not like touching files unrelated to the feature, increasing the blast radius and while i don't see anything wrong with changing the order, it may confuse folk who are using the raw data, since it does not follow any alphabetical ordering. I will revert these PR changes.

@garymccann
Sure thing.
I'll start canceling them if you haven't already. You got 'em. 🙂

There might be one or two items left for us to include on this PR, but we'll see as I take a gander now.

@garymccann garymccann force-pushed the u/garymccann-fix-xr7 branch from 57a329c to fb33403 Compare April 4, 2025 16:07
@garymccann garymccann requested a review from mjbear April 4, 2025 16:21
@mjbear mjbear changed the title Fixing XR7 related parse error where ARP EVPN line exists Fix XR7 parse error where ARP EVPN line exists Apr 4, 2025
@mjbear mjbear added the question label Apr 4, 2025
@mjbear mjbear self-requested a review April 5, 2025 14:46
mjbear added a commit to mjbear/ntc-templates that referenced this pull request May 6, 2025
@mjbear mjbear removed the question label May 9, 2025
@mjbear mjbear merged commit ec117cf into networktocode:master May 9, 2025
10 checks passed
mjbear added a commit to mjbear/ntc-templates that referenced this pull request May 9, 2025
mjbear added a commit to mjbear/ntc-templates that referenced this pull request May 9, 2025
jvanderaa pushed a commit that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants